usitebuilder Issue Tracker Rss Feed

Edited Unassigned: Datatype Prevalues Not Saving [17469]

dclapperton — Wed, 19 Jun 2013 10:07:05 GMT

Each time uSiteBuilder is published datatype prevalues are always recreated, causing properties to lose their selected values.

Currently the code is doing the following in DataTypeManager.cs :

```
if (prevalues.Any())
{
var settingsStorage = new DataEditorSettingsStorage();

// updating all settings to those defined in datatype class
// If you've exported, all settings will be defined here anyway?
settingsStorage.ClearSettings(dtd.Id);
settingsStorage.InsertSettings(dtd.Id, prevalues.Select(pre => new Setting<string, string> { Key = pre.Alias, Value = pre.Value }).ToList());
}
```

I Have added a small check to see if the values already exist before inserting:

```
if (prevalues.Any())
{
var settingsStorage = new DataEditorSettingsStorage();

List<Setting<string, string>> settings = settingsStorage.GetSettings(dtd.Id);

//only insert settings if they don't already exist
foreach (Setting<string, string> setting in settings)
{
if (!prevalues.Any(p => p.Alias == setting.Key && p.Value == setting.Value))
{
settingsStorage.InsertSetting(dtd.Id,setting.Key,setting.Value,0);
}
}
}
```

Created Unassigned: Datatype Prevalues Not Saving [17469]

dclapperton — Wed, 19 Jun 2013 10:05:36 GMT

Each time uSiteBuilder is published datatype prevalues are always recreated, means properties lose their selected values.

Currently the code is doing the following in DataTypeManager.cs :

```
if (prevalues.Any())
{
var settingsStorage = new DataEditorSettingsStorage();

// updating all settings to those defined in datatype class
// If you've exported, all settings will be defined here anyway?
settingsStorage.ClearSettings(dtd.Id);
settingsStorage.InsertSettings(dtd.Id, prevalues.Select(pre => new Setting<string, string> { Key = pre.Alias, Value = pre.Value }).ToList());
}
```

I Have added a small check to see if the values already exist before inserting:

```
if (prevalues.Any())
{
var settingsStorage = new DataEditorSettingsStorage();

List<Setting<string, string>> settings = settingsStorage.GetSettings(dtd.Id);

//only insert settings if they don't already exist
foreach (Setting<string, string> setting in settings)
{
if (!prevalues.Any(p => p.Alias == setting.Key && p.Value == setting.Value))
{
settingsStorage.InsertSetting(dtd.Id,setting.Key,setting.Value,0);
}
}
}
```

Created Issue: Exception thrown when trying to synchronise datatypes if a datatype with same name already exists [17468]

ProNotion — Mon, 02 Jul 2012 12:03:40 GMT

To reproduce, create a datatype through the UI then create a new datatype of the same name in code that inherits from DataTypeBase. Discussion/consensus required on how best to handle this - perhaps skip over the datatype as it already exists but may cause issues if people are referencing datatype via the CodeFirst implied GUID.

Commented Issue: Using dictionary items for tabnames [16803]

brianhdk — Sun, 29 Apr 2012 13:08:16 GMT

If you use dictionary items for tabnames will create a new tab every time that umbraco starts

Code to reproduce
[DocumentTypeProperty(UmbracoPropertyType.Textstring,
Tab = "#demotab",
Name = "#demoprop")]
public string Test { get; set; }
Comments: ** Comment from web user: brianhdk **

Any updates on this one?

Created Issue: CurrentContent is null when using siteBuilderSupressSynchronization = true [17467]

barnakles — Thu, 23 Feb 2012 11:00:00 GMT

Changeset 85517: When using the compiled DLL in an Umbraco site, 'CurrentContent' returns NULL when the web.config 'siteBuilderSupressSynchronization' key is true. Error does not occur when the key is set to false

Created Issue: Using dictionary items for tabnames [16803]

dawoe — Thu, 27 Oct 2011 12:16:17 GMT

Commented Issue: USiteBuilder prevents installer from running [16154]

barnakles — Tue, 23 Aug 2011 09:00:40 GMT

If Umbraco is not yet installed then the uSiteBuilder HttpHandler should exit immediately.
Comments: ** Comment from web user: barnakles **

Yes this caused my no end of grief on a site that needed a reinstall of the DB..

Commented Issue: Merge tabs when inheriting document types [16157]

vladanos — Thu, 21 Jul 2011 14:55:34 GMT

It should be possible to combine properties from base class and inheriting class into the same tab. As of v1.1 the inheriting document type will end up with two tabs with the same name.
Comments: ** Comment from web user: vladanos **

This is fixed in version 1.2 (already on codeplex) that will be released soon.

Created Issue: Use full namespace of class as document type alias [16265]

michielvoo — Tue, 19 Jul 2011 15:58:04 GMT

In code it's allowed to have two classes with the same name as long as they are in different namespaces. But uSiteBuilder doesn't use the namespace in the alias and then warns about unique names.

"Document type with alias 'X' already exists! Please use unique class names as class name is used as alias."

If we can override this behavior (and hopefully make it default) so that namespace AND class name are used that will open some new possibilities.

Created Issue: Merge tabs when inheriting document types [16157]

michielvoo — Thu, 23 Jun 2011 09:10:01 GMT

It should be possible to combine properties from base class and inheriting class into the same tab. As of v1.1 the inheriting document type will end up with two tabs with the same name.

Created Issue: Merge tabs when inheriting document types [16156]

michielvoo — Thu, 23 Jun 2011 09:09:27 GMT

It should be possible to combine progperties from base class and inheriting class into the same tab. As of v1.1 the inheriting document type will end up with two tabs with the same name.

Created Issue: USiteBuilder prevents installer from running [16154]

michielvoo — Thu, 23 Jun 2011 08:52:55 GMT

If Umbraco is not yet installed then thr USiteBuilder HttpHandler should exit immediately.

Created Issue: Add uSiteBuilder to NuGet [16151]

michielvoo — Wed, 22 Jun 2011 16:04:45 GMT

Please provide a NuGet package to install the assembly directly into a project from withing Visual Studio.

Created Issue: Download option for assembly only. [16150]

michielvoo — Wed, 22 Jun 2011 16:03:15 GMT

Please provide a package to download only the assembly.

Created Issue: Tab ordering and deletion [15758]

sebastiaan — Mon, 25 Apr 2011 19:44:48 GMT

It would be great to have the possibility to order tabs programatically instead of having to do it through the umbraco interface.

While you're adding this, I don't think it would be too difficult to allow the [Obsolete] attribute to be able to delete tabs, I'd recommend you only delete tabs when nothing it on them. Although, the properties that are on the deleted tab would automatically end up on the Generic Properties tab anyway, so that wouldn't be too much of a problem.